Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Menu in UIKitBackend #118

Merged
merged 4 commits into from
Mar 27, 2025
Merged

Implement Menu in UIKitBackend #118

merged 4 commits into from
Mar 27, 2025

Conversation

bbrk24
Copy link
Contributor

@bbrk24 bbrk24 commented Mar 19, 2025

Fixes #106

stackotter
stackotter requested changes Mar 25, 2025
View reviewed changes
Copy link
Owner

@stackotter stackotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks looks good, just a few small naming and formatting changes

stackotter
stackotter requested changes Mar 25, 2025
View reviewed changes
Copy link
Owner

@stackotter stackotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just submitting this review to save my reviewing progress, no new requested changes other than the existing transform discussion.

@bbrk24 bbrk24 requested a review from stackotter March 25, 2025 22:10
stackotter
stackotter approved these changes Mar 27, 2025
View reviewed changes
Copy link
Owner

@stackotter stackotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks for implementing this 🙏 I'll test it out locally and then merge

@stackotter stackotter merged commit 70fc5da into stackotter:main Mar 27, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stackotter stackotter stackotter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UIKitBackend support for Menu
2 participants
@bbrk24 @stackotter